OSDN Git Service

virtio-gpu: fix possible memory allocation failure
authorliuyuntao <liuyuntao10@huawei.com>
Sat, 28 Aug 2021 10:43:21 +0000 (18:43 +0800)
committerGerd Hoffmann <kraxel@redhat.com>
Fri, 17 Sep 2021 05:41:08 +0000 (07:41 +0200)
commit5bd4f20de8acad37dbb3154feb34dbc36d506c02
tree60e3829d543baf127195a2e3fa32e0abcbf4e16b
parent91241ee25a2f1fcaee69d81c68c541d7ec9d020a
virtio-gpu: fix possible memory allocation failure

When kmem_cache_zalloc in virtio_gpu_get_vbuf fails, it will return
an error code. But none of its callers checks this error code, and
a core dump will take place.

Considering many of its callers can't handle such error, I add
a __GFP_NOFAIL flag when calling kmem_cache_zalloc to make sure
it won't fail, and delete those unused error handlings.

Fixes: dc5698e80cf724 ("Add virtio gpu driver.")
Signed-off-by: Yuntao Liu <liuyuntao10@huawei.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20210828104321.3410312-1-liuyuntao10@huawei.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
drivers/gpu/drm/virtio/virtgpu_vq.c