OSDN Git Service

xfs: fix cil push sequence after log recovery
authorMark Tinguely <tinguely@sgi.com>
Thu, 24 Jul 2014 10:49:40 +0000 (20:49 +1000)
committerDave Chinner <david@fromorbit.com>
Thu, 24 Jul 2014 10:49:40 +0000 (20:49 +1000)
commit5c18717ea25fcb87c746deac1bf2ef2ff46e154a
treee3e730412cbfa4e831da455608ca47d0549ef129
parent2451337dd043901b5270b7586942abe564443e3d
xfs: fix cil push sequence after log recovery

When the CIL checkpoint is fully written to the log, the LSN of the checkpoint
commit record is written into the CIL context structure. This allows log force
waiters to correctly detect when the checkpoint they are waiting on have been
fully written into the log buffers.

However, the initial context after mount is initialised with a non-zero commit
LSN, so appears to waiters as though it is complete even though it may not have
even been pushed, let alone written to the log buffers. Hence a log force
immediately after a filesystem is mounted may not behave correctly, nor does
commit record ordering if multiple CIL pushes interleave immediately after
mount.

To fix this, make sure the initial context commit LSN is not touched until the
first checkpointis actually pushed.

[dchinner: rewrite commit message]

Signed-off-by: Mark Tinguely <tinguely@sgi.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_log_cil.c