OSDN Git Service

sctp: fix refcount bug in sctp_wfree
authorQiujun Huang <hqjagain@gmail.com>
Fri, 27 Mar 2020 03:07:51 +0000 (11:07 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 30 Mar 2020 04:57:30 +0000 (21:57 -0700)
commit5c3e82fe159622e46e91458c1a6509c321a62820
treee7bda32450ded263271390bb290f5b630e46b956
parentfbe4e0c1b298b4665ee6915266c9d6c5b934ef4a
sctp: fix refcount bug in sctp_wfree

We should iterate over the datamsgs to move
all chunks(skbs) to newsk.

The following case cause the bug:
for the trouble SKB, it was in outq->transmitted list

sctp_outq_sack
        sctp_check_transmitted
                SKB was moved to outq->sacked list
        then throw away the sack queue
                SKB was deleted from outq->sacked
(but it was held by datamsg at sctp_datamsg_to_asoc
So, sctp_wfree was not called here)

then migrate happened

        sctp_for_each_tx_datachunk(
        sctp_clear_owner_w);
        sctp_assoc_migrate();
        sctp_for_each_tx_datachunk(
        sctp_set_owner_w);
SKB was not in the outq, and was not changed to newsk

finally

__sctp_outq_teardown
        sctp_chunk_put (for another skb)
                sctp_datamsg_put
                        __kfree_skb(msg->frag_list)
                                sctp_wfree (for SKB)
SKB->sk was still oldsk (skb->sk != asoc->base.sk).

Reported-and-tested-by: syzbot+cea71eec5d6de256d54d@syzkaller.appspotmail.com
Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
Acked-by: Marcelo Ricardo Leitner <mleitner@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/socket.c