OSDN Git Service

KVM: arm64: Fix memory leak on stage2 update of a valid PTE
authorYanan Wang <wangyanan55@huawei.com>
Tue, 1 Dec 2020 20:10:32 +0000 (04:10 +0800)
committerMarc Zyngier <maz@kernel.org>
Wed, 2 Dec 2020 09:42:24 +0000 (09:42 +0000)
commit5c646b7e1d8bcb12317426287c516dfa4c5171c2
treee898f5189dcf00d995c7c7b36a9c8a29298167b3
parent23bde34771f1ea92fb5e6682c0d8c04304d34b3b
KVM: arm64: Fix memory leak on stage2 update of a valid PTE

When installing a new leaf PTE onto an invalid ptep, we need to
get_page(ptep) to account for the new mapping.

However, simply updating a valid PTE shouldn't result in any
additional refcounting, as there is new mapping. This otherwise
results in a page being forever wasted.

Address this by fixing-up the refcount in stage2_map_walker_try_leaf()
if the PTE was already valid, balancing out the later get_page()
in stage2_map_walk_leaf().

Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
[maz: update commit message, add comment in the code]
Signed-off-by: Marc Zyngier <maz@kernel.org>
Acked-by: Will Deacon <will@kernel.org>
Link: https://lore.kernel.org/r/20201201201034.116760-2-wangyanan55@huawei.com
arch/arm64/kvm/hyp/pgtable.c