OSDN Git Service

ASoC: soc-core: Fix regression causing sysfs entries to disappear
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Thu, 30 Jul 2020 12:07:14 +0000 (13:07 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 30 Jul 2020 18:57:09 +0000 (19:57 +0100)
commit5c74c9d34aec1ac756de6979dd5580096aba8643
tree9205a81dc481bcd2bf9ea5228205d20bcac69bb3
parentdc5fb6d2e8dff0dd61c9b55508c46e73a67e9ea8
ASoC: soc-core: Fix regression causing sysfs entries to disappear

The allocation order of things in soc_new_pcm_runtime was changed to
move the device_register before the allocation of the rtd structure.
This was to allow the rtd allocation to be managed by devm. However
currently the sysfs entries are added by device_register and their
visibility depends on variables within the rtd structure, this causes
the pmdown_time and dapm_widgets sysfs entries to be missing for all
rtds.

Correct this issue by manually calling device_add_groups after the
appropriate information is available.

Fixes: d918a37610b1 ("ASoC: soc-core: tidyup soc_new_pcm_runtime() alloc order")
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20200730120715.637-1-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-core.c