OSDN Git Service

media: adv7180: don't clear V4L2_SUBDEV_FL_IS_I2C
authorAkinobu Mita <akinobu.mita@gmail.com>
Thu, 19 Oct 2017 16:31:20 +0000 (12:31 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 31 Oct 2017 16:07:56 +0000 (12:07 -0400)
commit5cc72c472654c493c461898d892e87cde97994be
tree819a5973781fdab026ac05fb09b238f0ed4e6a48
parent3fa013be95bb046490d3b11d546bf06d73c7e0e3
media: adv7180: don't clear V4L2_SUBDEV_FL_IS_I2C

The v4l2_i2c_subdev_init() sets V4L2_SUBDEV_FL_IS_I2C flag in the
subdev->flags.  But this driver overwrites subdev->flags immediately after
calling v4l2_i2c_subdev_init().  So V4L2_SUBDEV_FL_IS_I2C is not set after
all.

This stops breaking subdev->flags and preserves V4L2_SUBDEV_FL_IS_I2C.

Side note: According to the comment in v4l2_device_unregister(), this is
problematic only if the device is platform bus device.  Device tree or
ACPI based devices are not affected.

Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/i2c/adv7180.c