OSDN Git Service

platform/x86: thinkpad_acpi: tpacpi_attr_group contains driver attributes not device...
authorHans de Goede <hdegoede@redhat.com>
Tue, 23 Nov 2021 21:04:21 +0000 (22:04 +0100)
committerHans de Goede <hdegoede@redhat.com>
Thu, 25 Nov 2021 15:22:50 +0000 (16:22 +0100)
commit5cd689683eb0507c67f825f1c29b17bb80612468
treeccd444caa7d2117ce41864b25cea575e3e2fa73c
parent2f5ad08f3eec8d4376b62f3fe708102f6aaea056
platform/x86: thinkpad_acpi: tpacpi_attr_group contains driver attributes not device attrs

Commit 79f960e29cfc ("platform/x86: thinkpad_acpi: Convert platform driver
to use dev_groups") put the debug_level, interface_version, version and the
THINKPAD_ACPI_DEBUGFACILITIES attributes in a new tpacpi_attr_group and
added those to the tpacpi_groups groups-array which is used to initialize
the driver.dev_groups member.

But before this commit these attributes were registered with
driver_create_file(), so they should be part of the groups-array which is
used to initialize the driver.groups member instead.

And also make the same change for the fan_watchdog hwmon driver attribute.

Fixes: 79f960e29cfc ("platform/x86: thinkpad_acpi: Convert platform driver to use dev_groups")
Cc: Len Baker <len.baker@gmx.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20211123210424.266607-4-hdegoede@redhat.com
drivers/platform/x86/thinkpad_acpi.c