OSDN Git Service

libnvdimm, region: Fail badblocks listing for inactive regions
authorDan Williams <dan.j.williams@intel.com>
Thu, 27 Sep 2018 22:01:55 +0000 (15:01 -0700)
committerDan Williams <dan.j.williams@intel.com>
Fri, 28 Sep 2018 18:12:34 +0000 (11:12 -0700)
commit5d394eee2c102453278d81d9a7cf94c80253486a
tree13aa5100525edf5f662942f4ecb34bcf4a8d93ef
parent48af2f7e52f4cd5eb41ebcd1bd2e326aa2d33d32
libnvdimm, region: Fail badblocks listing for inactive regions

While experimenting with region driver loading the following backtrace
was triggered:

 INFO: trying to register non-static key.
 the code is fine but needs lockdep annotation.
 turning off the locking correctness validator.
 [..]
 Call Trace:
  dump_stack+0x85/0xcb
  register_lock_class+0x571/0x580
  ? __lock_acquire+0x2ba/0x1310
  ? kernfs_seq_start+0x2a/0x80
  __lock_acquire+0xd4/0x1310
  ? dev_attr_show+0x1c/0x50
  ? __lock_acquire+0x2ba/0x1310
  ? kernfs_seq_start+0x2a/0x80
  ? lock_acquire+0x9e/0x1a0
  lock_acquire+0x9e/0x1a0
  ? dev_attr_show+0x1c/0x50
  badblocks_show+0x70/0x190
  ? dev_attr_show+0x1c/0x50
  dev_attr_show+0x1c/0x50

This results from a missing successful call to devm_init_badblocks()
from nd_region_probe(). Block attempts to show badblocks while the
region is not enabled.

Fixes: 6a6bef90425e ("libnvdimm: add mechanism to publish badblocks...")
Cc: <stable@vger.kernel.org>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/nvdimm/region_devs.c