OSDN Git Service

platform/x86: panasonic-laptop: filter out duplicate volume up/down/mute keypresses
authorHans de Goede <hdegoede@redhat.com>
Fri, 24 Jun 2022 11:23:39 +0000 (13:23 +0200)
committerHans de Goede <hdegoede@redhat.com>
Tue, 28 Jun 2022 19:45:40 +0000 (21:45 +0200)
commit5e24e1eca1f2a3aed924e44606134a9381c3ccb9
treee3c0b3fb47efd7e2bff3348db9366e1e2cdc6f34
parent027f88453dbf34cafce1c31e93c216665cdd71d2
platform/x86: panasonic-laptop: filter out duplicate volume up/down/mute keypresses

On some Panasonic models the volume up/down/mute keypresses get
reported both through the Panasonic ACPI HKEY interface as well as
through the atkbd device.

Filter out the atkbd scan-codes for these to avoid reporting presses
twice.

Note normally we would leave the filtering of these to userspace by mapping
the scan-codes to KEY_UNKNOWN through /lib/udev/hwdb.d/60-keyboard.hwdb.
However in this case that would cause regressions since we were filtering
the Panasonic ACPI HKEY events before, so filter these in the kernel.

Fixes: ed83c9171829 ("platform/x86: panasonic-laptop: Resolve hotkey double trigger bug")
Reported-and-tested-by: Stefan Seyfried <seife+kernel@b1-systems.com>
Reported-and-tested-by: Kenneth Chan <kenneth.t.chan@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20220624112340.10130-7-hdegoede@redhat.com
drivers/platform/x86/Kconfig
drivers/platform/x86/panasonic-laptop.c