OSDN Git Service

[X86] Remove ANY_EXTEND special case from canReduceVMulWidth
authorCraig Topper <craig.topper@intel.com>
Thu, 15 Nov 2018 21:19:32 +0000 (21:19 +0000)
committerCraig Topper <craig.topper@intel.com>
Thu, 15 Nov 2018 21:19:32 +0000 (21:19 +0000)
commit5e55bb95bb8b5ee66926b6c63bc63732b8ef828b
treea69f2c10945dabafdba27c72ab94ab9547b14105
parentdff71eafb8b6f13f5914746c3b8e5fb533f90d7d
[X86] Remove ANY_EXTEND special case from canReduceVMulWidth

Removing this code doesn't affect any lit tests so it doesn't appear to be tested anymore. I assume it was when it was added, but I guess something else changed? Code coverage report also says its unused.

I mostly didn't like that it seemed to count the sign bits as if it was a sign_extend, but then set isPositive as if it was a zero_extend. It feels like we should have picked one interpretation?

Differential Revision: https://reviews.llvm.org/D54596

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@346995 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Target/X86/X86ISelLowering.cpp