OSDN Git Service

net/sched: flower: Fix null pointer dereference when run tc vlan command
authorJianbo Liu <jianbol@mellanox.com>
Mon, 9 Jul 2018 02:26:20 +0000 (02:26 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 12 Jul 2018 05:48:13 +0000 (22:48 -0700)
commit5e9a0fe492f89ff1c7583ee6ea89dc37b8c2e5c2
tree83330d5b0d83102a537bbbff24a825748dcf5c5a
parentdb560d1612f81c932df8d31e6f3bf7581c32ba91
net/sched: flower: Fix null pointer dereference when run tc vlan command

Zahari issued tc vlan command without setting vlan_ethtype, which will
crash kernel. To avoid this, we must check tb[TCA_FLOWER_KEY_VLAN_ETH_TYPE]
is not null before use it.
Also we don't need to dump vlan_ethtype or cvlan_ethtype in this case.

Fixes: d64efd0926ba ('net/sched: flower: Add supprt for matching on QinQ vlan headers')
Signed-off-by: Jianbo Liu <jianbol@mellanox.com>
Reported-by: Zahari Doychev <zahari.doychev@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_flower.c