OSDN Git Service

Revert "drm/i915: Don't use VBT for detecting DPCD backlight controls"
authorLyude Paul <lyude@redhat.com>
Tue, 4 Feb 2020 19:28:09 +0000 (14:28 -0500)
committerJani Nikula <jani.nikula@intel.com>
Fri, 7 Feb 2020 11:06:54 +0000 (13:06 +0200)
commit5eae8ca3738e8bec249d68422d9323cea670ff42
tree192bd6b7c8b75be8f54d338a1eaa9d6877c5bc5c
parentf14f27b1663269a81ed62d3961fe70250a1a0623
Revert "drm/i915: Don't use VBT for detecting DPCD backlight controls"

This reverts commit d2a4bb6f8bc8cf2d788adf7e59b5b52fe3a3333c.

So, turns out that this ended up just breaking things. While many
laptops incorrectly advertise themselves as supporting PWM backlight
controls, they actually will only work with DPCD backlight controls.
Unfortunately, it also seems there are a number of systems which
advertise DPCD backlight controls in their eDP DPCD but don't actually
support them. Talking with some laptop manufacturers has shown it might
be possible to probe this support via the EDID (!?!?) but I haven't been
able to confirm that this would work on any other manufacturer's
systems.

So in the mean time, we'll just revert this commit for now and go back
to the old way of doing things.

Fixes: d2a4bb6f8bc8 ("drm/i915: Don't use VBT for detecting DPCD backlight controls")
Signed-off-by: Lyude Paul <lyude@redhat.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200204192823.111404-2-lyude@redhat.com
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c