OSDN Git Service

net: mii: Fix autoneg in mii_lpa_to_linkmode_lpa_t()
authorAndrew Lunn <andrew@lunn.ch>
Wed, 5 Dec 2018 20:49:40 +0000 (21:49 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Dec 2018 00:26:16 +0000 (16:26 -0800)
commit5f15eed245bc6d7c82d44f0ebcaf62071a9d55bd
treebdc52d9ab8e25aa95f33276c62d01c6ef77a32a8
parentb255e500c8dc111dd9efac1442a85a0dac913feb
net: mii: Fix autoneg in mii_lpa_to_linkmode_lpa_t()

mii_adv_to_linkmode_adv_t() clears all bits before setting it needs to
set. This means the freshly set Autoneg gets cleared.

Change the order, and add comments about it clearing the old content
of the bitmap.

Fixes: c0ec3c273677 ("net: phy: Convert u32 phydev->lp_advertising to linkmode")
Reported-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/mii.h