OSDN Git Service

drm/vc4: perfmon: Fix variable dereferenced before check
authorMaxime Ripard <maxime@cerno.tech>
Wed, 22 Jun 2022 08:02:43 +0000 (10:02 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Mon, 27 Jun 2022 13:43:14 +0000 (15:43 +0200)
commit5f701324c0fb6f9f5aaac3f8d1575321375f6d8f
tree8752c38c319c24413622731953030ee0f87c13f4
parent85016f66af8506cb601fd4f4fde23ed327a266be
drm/vc4: perfmon: Fix variable dereferenced before check

Commit 30f8c74ca9b7 ("drm/vc4: Warn if some v3d code is run on BCM2711")
introduced a check in vc4_perfmon_get() that dereferences a pointer before
we checked whether that pointer is valid or not.

Let's rework that function a bit to do things in the proper order.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 30f8c74ca9b7 ("drm/vc4: Warn if some v3d code is run on BCM2711")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Reviewed-by: José Expósito <jose.exposito89@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220622080243.22119-1-maxime@cerno.tech
drivers/gpu/drm/vc4/vc4_perfmon.c