OSDN Git Service

libertas: Use struct_group() for memcpy() region
authorKees Cook <keescook@chromium.org>
Thu, 18 Nov 2021 18:41:04 +0000 (10:41 -0800)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 29 Nov 2021 10:44:29 +0000 (12:44 +0200)
commit5fd32ae0433a7af37eac27ace3aabae8cb7c2fc4
tree50279826340cd7861f94e4e6bdde80a66979a21d
parentfa4408b0799a7d52ec0b28f97ab0a93401e8e83f
libertas: Use struct_group() for memcpy() region

In preparation for FORTIFY_SOURCE performing compile-time and run-time
field bounds checking for memcpy(), memmove(), and memset(), avoid
intentionally writing across neighboring fields.

Use struct_group() in struct txpd around members tx_dest_addr_high
and tx_dest_addr_low so they can be referenced together. This will
allow memcpy() and sizeof() to more easily reason about sizes, improve
readability, and avoid future warnings about writing beyond the end
of queue_id.

"pahole" shows no size nor member offset changes to struct txpd.
"objdump -d" shows no object code changes.

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20211118184104.1283637-1-keescook@chromium.org
drivers/net/wireless/marvell/libertas/host.h
drivers/net/wireless/marvell/libertas/tx.c