OSDN Git Service

rocker: fix rocker_tlv_put_* functions for KASAN
authorArnd Bergmann <arnd@arndb.de>
Fri, 22 Sep 2017 21:29:18 +0000 (23:29 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 26 Sep 2017 03:18:27 +0000 (20:18 -0700)
commit6098d7ddd62f532f80ee2a4b01aca500a8e4e9e4
tree85e73b083c7a0caa504cfc18f19512c18f775b2d
parenta93ad944f4ff9a797abff17c73fc4b1e4a1d9141
rocker: fix rocker_tlv_put_* functions for KASAN

Inlining these functions creates lots of stack variables that each take
64 bytes when KASAN is enabled, leading to this warning about potential
stack overflow:

drivers/net/ethernet/rocker/rocker_ofdpa.c: In function 'ofdpa_cmd_flow_tbl_add':
drivers/net/ethernet/rocker/rocker_ofdpa.c:621:1: error: the frame size of 2752 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]

gcc-8 can now consolidate the stack slots itself, but on older versions
we get the same behavior by using a temporary variable that holds a
copy of the inline function argument.

Cc: stable@vger.kernel.org
Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/rocker/rocker_tlv.h