OSDN Git Service

Combine index_info and find_secondary_indexes into a single routine that
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 21 Nov 1999 23:25:47 +0000 (23:25 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 21 Nov 1999 23:25:47 +0000 (23:25 +0000)
commit610dfa6d5560ebcd72ecca82c64c91503efc9bc5
tree79b676d6133877f8e790e5324005666c92e96b00
parent40d3e9254101d23c4f70b95d621277d306c7baf1
Combine index_info and find_secondary_indexes into a single routine that
returns a list of RelOptInfos, eliminating the need for static state
in index_info.  That static state was a direct cause of coredumps; if
anything decided to elog(ERROR) partway through an index_info search of
pg_index, the next query would try to close a scan pointer that was
pointing at no-longer-valid memory.  Another example of the reasons to
avoid static state variables...
src/backend/optimizer/util/indexnode.c
src/backend/optimizer/util/plancat.c
src/include/optimizer/plancat.h