OSDN Git Service

ASoC: soc-pcm: add error log
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thu, 18 Feb 2021 22:19:19 +0000 (16:19 -0600)
committerMark Brown <broonie@kernel.org>
Wed, 10 Mar 2021 13:06:56 +0000 (13:06 +0000)
commit61456212e80ee274828d2d14fcc7b9364dfc0744
tree6e5a4383bae0272adc83caf0640dcdea05f545a7
parent61b9eedd93b1f55e922dfd3ac3cb844e2b69b808
ASoC: soc-pcm: add error log

cppcheck warning:

sound/soc/soc-pcm.c:1907:6: style: Variable 'err' is assigned a value
that is never used. [unreadVariable]
 err = dpcm_be_dai_hw_free(fe, stream);
     ^

it's not clear why dpcm_be_dai_hw_free() is sometimes called without
testing the error status, and sometimes an error message is provided.

When in doubt, add an error message for consistency. This may have to
be revisited.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210218221921.88991-5-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-pcm.c