OSDN Git Service

nfc: s3fwrn5: replace the assertion with a WARN_ON
authorAditya Pakki <pakki001@umn.edu>
Tue, 17 Dec 2019 20:43:00 +0000 (14:43 -0600)
committerDavid S. Miller <davem@davemloft.net>
Fri, 20 Dec 2019 01:33:23 +0000 (17:33 -0800)
commit615f22f58029aa747b12768985e7f91cd053daa2
treeeb400c7346bab7b096faa5c553553397df76b728
parenta019739c1c32cbd07f62b1d84fa57620897464b1
nfc: s3fwrn5: replace the assertion with a WARN_ON

In s3fwrn5_fw_recv_frame, if fw_info->rsp is not empty, the
current code causes a crash via BUG_ON. However, s3fwrn5_fw_send_msg
does not crash in such a scenario. The patch replaces the BUG_ON
by returning the error to the callers and frees up skb.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/nfc/s3fwrn5/firmware.c