OSDN Git Service

spi: qup: Don't skip cleanup in remove's error path
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thu, 30 Mar 2023 21:03:40 +0000 (23:03 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 4 Apr 2023 11:46:48 +0000 (12:46 +0100)
commit61f49171a43ab1f80c73c5c88c508770c461e0f2
tree636a2c56fa0790e703d881633497f26c39ed08aa
parentc2912d42e86e494935722669e4d9eade69649072
spi: qup: Don't skip cleanup in remove's error path

Returning early in a platform driver's remove callback is wrong. In this
case the dma resources are not released in the error path. this is never
retried later and so this is a permanent leak. To fix this, only skip
hardware disabling if waking the device fails.

Fixes: 64ff247a978f ("spi: Add Qualcomm QUP SPI controller support")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230330210341.2459548-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-qup.c