OSDN Git Service

risc-v: Fix order of IPI enablement vs RCU startup
authorMarc Zyngier <maz@kernel.org>
Mon, 3 Jul 2023 18:31:26 +0000 (19:31 +0100)
committerPalmer Dabbelt <palmer@rivosinc.com>
Wed, 5 Jul 2023 14:24:38 +0000 (07:24 -0700)
commit6259f3443c6a376aa077816ac92e9ddeb0817d09
treefbb355f0e1494bf6e3f4e38e7cde3f349a608e33
parent62ba41d2761206664a1fdc998051324457da2dd6
risc-v: Fix order of IPI enablement vs RCU startup

Conor reports that risc-v tries to enable IPIs before telling the
core code to enable RCU. With the introduction of the mapple tree
as a backing store for the irq descriptors, this results in
a very shouty boot sequence, as RCU is legitimately upset.

Restore some sanity by moving the risc_ipi_enable() call after
notify_cpu_starting(), which explicitly enables RCU on the calling
CPU.

Fixes: 832f15f42646 ("RISC-V: Treat IPIs as normal Linux IRQs")
Reported-by: Conor Dooley <conor@kernel.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20230703-dupe-frying-79ae2ccf94eb@spud
Cc: Anup Patel <apatel@ventanamicro.com>
Cc: Palmer Dabbelt <palmer@rivosinc.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Tested-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20230703183126.1567625-1-maz@kernel.org
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
arch/riscv/kernel/smpboot.c