OSDN Git Service

ipv4: provide stronger user input validation in nl_fib_input()
authorEric Dumazet <edumazet@google.com>
Wed, 22 Mar 2017 02:22:28 +0000 (19:22 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Mar 2017 07:41:22 +0000 (09:41 +0200)
commit62e85fe590721acf19dfc7f8fcdd0f3eb8fc6ac5
treec2e7df47d2bcf8400c0a267ff0cfa79b1f350e4e
parent2f94dd54cfe64a9f49e49c0856640c11fd1c9bc0
ipv4: provide stronger user input validation in nl_fib_input()

[ Upstream commit c64c0b3cac4c5b8cb093727d2c19743ea3965c0b ]

Alexander reported a KMSAN splat caused by reads of uninitialized
field (tb_id_in) from user provided struct fib_result_nl

It turns out nl_fib_input() sanity tests on user input is a bit
wrong :

User can pretend nlh->nlmsg_len is big enough, but provide
at sendmsg() time a too small buffer.

Reported-by: Alexander Potapenko <glider@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/fib_frontend.c