OSDN Git Service

can: gs_usb: remove dma allocations
authorVasanth Sadhasivan <vasanth.sadhasivan@samsara.com>
Tue, 20 Sep 2022 15:47:24 +0000 (11:47 -0400)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 23 Sep 2022 11:55:00 +0000 (13:55 +0200)
commit62f102c0d1563ff6a31082f5d83b886ad2ff7ca0
tree6c869d9415917ed747884149ab0b11b2b3c4f9f0
parent906e0e6886afcad6f9cd86660d4b0bdf63f4f200
can: gs_usb: remove dma allocations

DMA allocated buffers are a precious resource. If there is no need for
DMA allocations, then it might be worth to use non-dma allocated
buffers.

After testing the gs_usb driver with and without DMA allocation, there
does not seem to be a significant change in latency or CPU utilization
either way. Therefore, DMA allocation is not necessary and removed.

Internal buffers used within urbs were managed and freed manually.
These buffers are no longer needed to be managed by the driver. The
URB_FREE_BUFFER flag, allows for the buffers in question to be
automatically freed.

Co-developed-by: Rhett Aultman <rhett.aultman@samsara.com>
Signed-off-by: Rhett Aultman <rhett.aultman@samsara.com>
Signed-off-by: Vasanth Sadhasivan <vasanth.sadhasivan@samsara.com>
Link: https://lore.kernel.org/all/20220920154724.861093-2-rhett.aultman@samsara.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/usb/gs_usb.c