OSDN Git Service

mesa/fbobject: Update CubeMapFace when reusing textures
authorNanley Chery <nanley.g.chery@intel.com>
Wed, 16 Nov 2016 00:42:23 +0000 (16:42 -0800)
committerEmil Velikov <emil.l.velikov@gmail.com>
Fri, 16 Dec 2016 12:01:23 +0000 (12:01 +0000)
commit63bdcc5c88441c4226d3717a5fb51e01b144bc2f
treee46a9062387721cb576a90a87fd47e074084d9d6
parentfb9f0a1197e10f9b1c727b5b2956f36827308ad1
mesa/fbobject: Update CubeMapFace when reusing textures

Framebuffer attachments can be specified through FramebufferTexture*
calls. Upon specifying a depth (or stencil) framebuffer attachment that
internally reuses a texture, the cube map face of the new attachment
would not be updated (defaulting to TEXTURE_CUBE_MAP_POSITIVE_X).
Fix this issue by actually updating the CubeMapFace field.

This bug manifested itself in BindFramebuffer calls performed on
framebuffers whose stencil attachments internally reused a depth
texture.  When binding a framebuffer, we walk through the framebuffer's
attachments and update each one's corresponding gl_renderbuffer. Since
the framebuffer's depth and stencil attachments may share a
gl_renderbuffer and the walk visits the stencil attachment after
the depth attachment, the uninitialized CubeMapFace forced rendering
to TEXTURE_CUBE_MAP_POSITIVE_X.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77662
Signed-off-by: Nanley Chery <nanley.g.chery@intel.com>
Reviewed-by: Brian Paul <brianp@vmware.com>
(cherry picked from commit 63318d34acd4a5edb271d57adf3b01e2e52552f8)
src/mesa/main/fbobject.c