OSDN Git Service

net: stmmac: optimize locking around PTP clock reads
authorYannick Vignon <yannick.vignon@nxp.com>
Fri, 4 Feb 2022 13:55:44 +0000 (14:55 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 8 Feb 2022 03:59:13 +0000 (19:59 -0800)
commit642436a1ad34a28c45bbc2bdc131640a73782356
tree55e9ca887936fe33d053986f223f542d7c0cdb70
parentd1d5bd647c49c8d4f8f4c5b79ddc819a6f3f7c57
net: stmmac: optimize locking around PTP clock reads

Reading the PTP clock is a simple operation requiring only 3 register
reads. Under a PREEMPT_RT kernel, protecting those reads by a spin_lock is
counter-productive: if the 2nd task preempting the 1st has a higher prio
but needs to read time as well, it will require 2 context switches, which
will pretty much always be more costly than just disabling preemption for
the duration of the reads. Moreover, with the code logic recently added
to get_systime(), disabling preemption is not even required anymore:
reads and writes just need to be protected from each other, to prevent a
clock read while the clock is being updated.

Improve the above situation by replacing the PTP spinlock by a rwlock, and
using read_lock for PTP clock reads so simultaneous reads do not block
each other.

Signed-off-by: Yannick Vignon <yannick.vignon@nxp.com>
Link: https://lore.kernel.org/r/20220204135545.2770625-1-yannick.vignon@oss.nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
drivers/net/ethernet/stmicro/stmmac/stmmac.h
drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c
drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c