OSDN Git Service

can: m_can: m_can_receive_skb(): add missing error handling to can_rx_offload_queue_s...
authorMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 1 Apr 2021 08:37:31 +0000 (10:37 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 7 Apr 2021 07:31:28 +0000 (09:31 +0200)
commit644022b1de9efc901494b8931c78700d49d35d3d
tree811325e66ef0d297d4e28ff831766494fb6e11dd
parentc8129487441e11617fab9770d9f98d9ae8fc7b3a
can: m_can: m_can_receive_skb(): add missing error handling to can_rx_offload_queue_sorted() call

In commit 1be37d3b0414 ("can: m_can: fix periph RX path: use
rx-offload to ensure skbs are sent from softirq context") the RX path
for peripherals (i.e. SPI based m_can controllers) was converted to
the rx-offload infrastructure. However, the error handling for
can_rx_offload_queue_sorted() was forgotten.
can_rx_offload_queue_sorted() will return with an error if the
internal queue is full.

This patch adds the missing error handling, by increasing the
rx_fifo_errors.

Fixes: 1be37d3b0414 ("can: m_can: fix periph RX path: use rx-offload to ensure skbs are sent from softirq context")
Link: https://lore.kernel.org/r/20210401084515.1455013-1-mkl@pengutronix.de
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1503583 ("Error handling issues")
Reviewed-by: Kees Cook <keescook@chromium.org>
Cc: Torin Cooper-Bennun <torin@maxiluxsystems.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/m_can/m_can.c