OSDN Git Service

ALSA: firewire-digi00x: fix wrong reference count for stream functionality at error...
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Sun, 7 Jul 2019 05:20:10 +0000 (14:20 +0900)
committerTakashi Iwai <tiwai@suse.de>
Sun, 7 Jul 2019 09:19:57 +0000 (11:19 +0200)
commit64582c56a9156ce88297a89a3b8ba03754e7149a
tree176989f7160c34c072af0aacc0cea9c66557ddfe
parente79c3f0c006ec26d0de5ba9747f65b81c16f83f1
ALSA: firewire-digi00x: fix wrong reference count for stream functionality at error path of rawmidi interface

In IEC 61883-6, several types of sampling data can be multiplexed into
payload of common isochronous packet (CIP). For typical audio and music
units, PCM samples and MIDI messages are multiplexed into one packet
streaming.

ALSA firewire-digi00x driver allows applications of rawmidi interface to
start packet streaming for transmission of MIDI messages. However at
error path, the reference count of stream functionality is not operated
correctly. This can brings a bug that packet streaming is not stopped
when all referrers release the count.

This commit fixes the bug.

Fixes: ae8ffbb26512 ("ALSA: firewire-digi00x: reserve/release isochronous resources in pcm.hw_params/hw_free callbacks")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/digi00x/digi00x-midi.c