OSDN Git Service

[PATCH] SCTP: Always linearise packet on input
authorHerbert Xu <herbert@gondor.apana.org.au>
Wed, 1 Nov 2006 05:34:20 +0000 (21:34 -0800)
committerWilly Tarreau <w@1wt.eu>
Sat, 4 Nov 2006 21:38:24 +0000 (22:38 +0100)
commit64a43003f4360fc7f9157fde4c380535be7de5fa
tree37621a85f3b2c98b3c213902232f30fc588556d6
parentabf857e7a1cbfd9a2d4e72d22bd6ac0f8a69d1b3
[PATCH] SCTP: Always linearise packet on input

(backported from 2.6-stable)

I was looking at a RHEL5 bug report involving Xen and SCTP
(https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212550).
It turns out that SCTP wasn't written to handle skb fragments at
all.  The absence of any calls to skb_may_pull is testament to
that.

It just so happens that Xen creates fragmented packets more often
than other scenarios (header & data split when going from domU to
dom0).  That's what caused this bug to show up.

Until someone has the time sits down and audits the entire net/sctp
directory, here is a conservative and safe solution that simply
linearises all packets on input.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
For 2.4 backport :
Acked-by: David S. Miller <davem@davemloft.net>
net/sctp/input.c