OSDN Git Service

[globalisel][tablegen] Generate rule coverage and use it to identify untested rules
authorDaniel Sanders <daniel_l_sanders@apple.com>
Thu, 16 Nov 2017 00:46:35 +0000 (00:46 +0000)
committerDaniel Sanders <daniel_l_sanders@apple.com>
Thu, 16 Nov 2017 00:46:35 +0000 (00:46 +0000)
commit64b77007a6d25d832d1ff55939d7eace23e15c6f
tree59d88e385c22d048a7e0c2e4be6538a76b49bf8e
parent93d7d4e1d2b4cd1ce0f9d77aac4a58dd48a9aba7
[globalisel][tablegen] Generate rule coverage and use it to identify untested rules

Summary:
This patch adds a LLVM_ENABLE_GISEL_COV which, like LLVM_ENABLE_DAGISEL_COV,
causes TableGen to instrument the generated table to collect rule coverage
information. However, LLVM_ENABLE_GISEL_COV goes a bit further than
LLVM_ENABLE_DAGISEL_COV. The information is written to files
(${CMAKE_BINARY_DIR}/gisel-coverage-* by default). These files can then be
concatenated into ${LLVM_GISEL_COV_PREFIX}-all after which TableGen will
read this information and use it to emit warnings about untested rules.

This technique could also be used by SelectionDAG and can be further
extended to detect hot rules and give them priority over colder rules.

Usage:
* Enable LLVM_ENABLE_GISEL_COV in CMake
* Build the compiler and run some tests
* cat gisel-coverage-[0-9]* > gisel-coverage-all
* Delete lib/Target/*/*GenGlobalISel.inc*
* Build the compiler

Known issues:
* ${LLVM_GISEL_COV_PREFIX}-all must be generated as a manual
  step due to a lack of a portable 'cat' command. It should be the
  concatenation of all ${LLVM_GISEL_COV_PREFIX}-[0-9]* files.
* There's no mechanism to discard coverage information when the ruleset
  changes

Depends on D39742

Reviewers: ab, qcolombet, t.p.northover, aditya_nandakumar, rovka

Reviewed By: rovka

Subscribers: vsk, arsenm, nhaehnle, mgorny, kristof.beyls, javed.absar, igorb, llvm-commits

Differential Revision: https://reviews.llvm.org/D39747

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@318356 91177308-0d34-0410-b5e6-96231b3b80d8
17 files changed:
CMakeLists.txt
cmake/modules/TableGen.cmake
include/llvm/CodeGen/GlobalISel/InstructionSelector.h
include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h
include/llvm/Config/config.h.cmake
include/llvm/Support/CodeGenCoverage.h [new file with mode: 0644]
lib/CodeGen/GlobalISel/InstructionSelect.cpp
lib/Support/CMakeLists.txt
lib/Support/CodeGenCoverage.cpp [new file with mode: 0644]
lib/Target/AArch64/AArch64InstructionSelector.cpp
lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
lib/Target/AMDGPU/AMDGPUInstructionSelector.h
lib/Target/ARM/ARMInstructionSelector.cpp
lib/Target/X86/X86InstructionSelector.cpp
test/TableGen/GlobalISelEmitter.td
utils/TableGen/GlobalISelEmitter.cpp
utils/llvm-gisel-cov.py [new file with mode: 0644]