OSDN Git Service

Revert "ANDROID: sched/tune: Initialize raw_spin_lock in boosted_groups"
authorVikram Mulukutla <markivx@codeaurora.org>
Fri, 22 Sep 2017 00:24:24 +0000 (17:24 -0700)
committerAndres Oportus <andresoportus@google.com>
Sat, 23 Sep 2017 01:25:03 +0000 (01:25 +0000)
commit650b6a5c418563f2a6cb4f12b3402a5b4870eea8
treefd47a0ab34c39d0ab943ef7a32b1a6fb281bf726
parent047200481e7f98e6334d751010c9470efb531b71
Revert "ANDROID: sched/tune: Initialize raw_spin_lock in boosted_groups"

This reverts commit c5616f2f874faa20b59b116177b99bf3948586df.

If we re-init the per-cpu boostgroup spinlock every time that
we add a new boosted cgroup, we can easily wipe out (reinit)
a spinlock struct while in a critical section. We should only
be setting up the per-cpu boostgroup data, and the spin_lock
initialization need only happen once - which we're already
doing in a postcore_initcall.

For example:

     -------- CPU 0 --------   | -------- CPU1 --------
cgroupX boost group added      |
schedtune_enqueue_task         |
  acquires(bg->lock)           | cgroupY boost group added
                               |  for_each_cpu()
                               |    raw_spin_lock_init(bg->lock)
  releases(bg->lock)           |
      BUG (already unlocked)   |
                               |

This results in the following BUG from the debug spinlock code:
BUG: spinlock already unlocked on CPU#5, rcuop/6/68

Change-Id: I3016702780b461a0cd95e26c538cd18df27d6316
Signed-off-by: Vikram Mulukutla <markivx@codeaurora.org>
kernel/sched/tune.c