OSDN Git Service

drm/vc4: Fix the "no scaling" case on multi-planar YUV formats
authorBoris Brezillon <boris.brezillon@bootlin.com>
Wed, 25 Jul 2018 12:29:07 +0000 (14:29 +0200)
committerSean Paul <seanpaul@chromium.org>
Mon, 10 Sep 2018 20:01:22 +0000 (16:01 -0400)
commit658d8cbd07dae22ccecf49399e18c609c4e85c53
treeeebc6c472ee93eaae625aae8822f9af8b7345b7c
parent67c6ed7cf9ebe53815f15bfdeb49ad91801c2235
drm/vc4: Fix the "no scaling" case on multi-planar YUV formats

When there's no scaling requested ->is_unity should be true no matter
the format.

Also, when no scaling is requested and we have a multi-planar YUV
format, we should leave ->y_scaling[0] to VC4_SCALING_NONE and only
set ->x_scaling[0] to VC4_SCALING_PPF.

Doing this fixes an hardly visible artifact (seen when using modetest
and a rather big overlay plane in YUV420).

Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.")
Cc: <stable@vger.kernel.org>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20180725122907.13702-1-boris.brezillon@bootlin.com
Signed-off-by: Sean Paul <seanpaul@chromium.org>
drivers/gpu/drm/vc4/vc4_plane.c