OSDN Git Service

selinux: fix double free
authorTom Rix <trix@redhat.com>
Wed, 10 Jun 2020 21:57:13 +0000 (14:57 -0700)
committerPaul Moore <paul@paul-moore.com>
Thu, 11 Jun 2020 02:10:35 +0000 (22:10 -0400)
commit65de50969a77509452ae590e9449b70a22b923bb
tree3237e1922915349ab6ec6406b5fec8c7f5ba1879
parentfe5a90b8c14914397a3bb0c214d142103c1ba3bf
selinux: fix double free

Clang's static analysis tool reports these double free memory errors.

security/selinux/ss/services.c:2987:4: warning: Attempt to free released memory [unix.Malloc]
                        kfree(bnames[i]);
                        ^~~~~~~~~~~~~~~~
security/selinux/ss/services.c:2990:2: warning: Attempt to free released memory [unix.Malloc]
        kfree(bvalues);
        ^~~~~~~~~~~~~~

So improve the security_get_bools error handling by freeing these variables
and setting their return pointers to NULL and the return len to 0

Cc: stable@vger.kernel.org
Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
security/selinux/ss/services.c