OSDN Git Service

bcma: Fix 'allmodconfig' and BCMA builds on MIPS targets
authorGuenter Roeck <linux@roeck-us.net>
Sun, 14 Jan 2018 21:34:02 +0000 (13:34 -0800)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 16 Jan 2018 19:13:55 +0000 (21:13 +0200)
commit664eadd6f44b3d71dcc62d0a825319000de0d5c9
tree6884b3fb1d7a881688654b5899301648a9f51aa7
parent49fdde89e2b8574cb55f99b57b7798f44567bc4b
bcma: Fix 'allmodconfig' and BCMA builds on MIPS targets

Mips builds with BCMA host mode enabled fail in mainline and -next
with:

In file included from include/linux/bcma/bcma.h:10:0,
                 from drivers/bcma/bcma_private.h:9,
 from drivers/bcma/main.c:8:
include/linux/bcma/bcma_driver_pci.h:218:24: error:
field 'pci_controller' has incomplete type

Bisect points to commit d41e6858ba58c ("MIPS: Kconfig: Set default MIPS
system type as generic") as the culprit. Analysis shows that the commmit
changes PCI configuration and enables PCI_DRIVERS_GENERIC. This in turn
disables PCI_DRIVERS_LEGACY. 'struct pci_controller' is, however, only
defined if PCI_DRIVERS_LEGACY is enabled.

Ultimately that means that BCMA_DRIVER_PCI_HOSTMODE depends on
PCI_DRIVERS_LEGACY. Add the missing dependency.

Fixes: d41e6858ba58c ("MIPS: Kconfig: Set default MIPS system type as ...")
Cc: Matt Redfearn <matt.redfearn@imgtec.com>
Cc: James Hogan <jhogan@kernel.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: James Hogan <jhogan@kernel.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/bcma/Kconfig