OSDN Git Service

drm_hwcomposer: Quiet noisy errors when planes don't support various attributes
authorJohn Stultz <john.stultz@linaro.org>
Tue, 24 Aug 2021 04:59:25 +0000 (04:59 +0000)
committerJohn Stultz <john.stultz@linaro.org>
Tue, 24 Aug 2021 05:02:12 +0000 (05:02 +0000)
commit66763d51428e5ca834e9cc29ad86299ac06381dd
tree055f946087c005dd226247491f9f1fff539659e8
parent8adf544306db75a3fb0843b9977693d2a817bf5d
drm_hwcomposer: Quiet noisy errors when planes don't support various attributes

If a plane doesn't support alpha or rotation, and IsValidForLayer()
fails, we see lots of logcat noise to the effect of:
08-24 04:45:42.957   453   453 E hwc-platform: Failed to emplace layer 0, dropping it
08-24 04:45:42.957   453   453 E hwc-platform: Failed provision stage with ret -22
08-24 04:45:42.957   453   453 E hwc-drm-display-composition: Planner failed provisioning planes ret=-22
08-24 04:45:42.957   453   453 E hwc-drm-two: Failed to plan the composition ret=-22

This noise is unneccessarily worrisome, as they don't really
help explain why things fail, and we still fall back to client
composing and frames are correctly composited.

Thus, this patch switches the errors to verbose-level warnings,
which match the level in IsValidForLayer() which explain what
actually is going wrong.

Change-Id: I7ed06906b8d9e02e6ec0ac50a94346e9f9c05ac6
Signed-off-by: John Stultz <john.stultz@linaro.org>
DrmHwcTwo.cpp
compositor/DrmDisplayComposition.cpp
compositor/Planner.cpp