OSDN Git Service

can: kvaser_usb: Fix accessing freed memory in kvaser_usb_start_xmit()
authorJimmy Assarsson <jimmyassarsson@gmail.com>
Mon, 6 Aug 2018 13:14:49 +0000 (15:14 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Nov 2018 15:13:09 +0000 (16:13 +0100)
commit667bd202c5aa10d62afabd5b748bd6709227e88b
tree550b09dcfb15f3f3947bfad5d39029fef482af46
parenta0d5745e5a1c03650bb9f8012afda790e7910c07
can: kvaser_usb: Fix accessing freed memory in kvaser_usb_start_xmit()

commit e13fb9b37cc00616b90df2d620f30345b5ada6ff upstream.

The call to can_put_echo_skb() may result in the skb being freed. The skb
is later used in the call to dev->ops->dev_frame_to_cmd().

This is avoided by moving the call to can_put_echo_skb() after
dev->ops->dev_frame_to_cmd().

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jimmy Assarsson <jimmyassarsson@gmail.com>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c