OSDN Git Service

drm/i915/gt: Protect signaler walk with RCU
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 20 Feb 2020 07:50:20 +0000 (07:50 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Thu, 20 Feb 2020 13:27:23 +0000 (13:27 +0000)
commit66940061a52fba730fdb49e133502e19be684202
tree95e7e36c40ff4e23a8fb5daf9c94e432cb212e92
parentdf6b1f3da89f1ff87399316c836fc3981de96c38
drm/i915/gt: Protect signaler walk with RCU

While we know that the waiters cannot disappear as we walk our list
(only that they might be added), the same cannot be said for our
signalers as they may be completed by the HW and retired as we process
this request. Ergo we need to use rcu to protect the list iteration and
remember to mark up the list_del_rcu.

v2: Mark the deps as safe-for-rcu

Fixes: 793c22617367 ("drm/i915/gt: Protect execlists_hold/unhold from new waiters")
Fixes: 32ff621fd744 ("drm/i915/gt: Allow temporary suspension of inflight requests")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200220075025.1539375-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gt/intel_lrc.c
drivers/gpu/drm/i915/i915_scheduler.c