OSDN Git Service

drm/bridge: tc358767: ensure DP is disabled before LT
authorTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 28 May 2019 08:27:35 +0000 (11:27 +0300)
committerAndrzej Hajda <a.hajda@samsung.com>
Fri, 31 May 2019 13:41:23 +0000 (15:41 +0200)
commit67bca92fa83089e7091e7210777b2f9ea17e5f87
treeb90293487b0ff5cb4350d11db3d131070e247443
parent1c928267b187a59ce96972a3102acb9ba72890e1
drm/bridge: tc358767: ensure DP is disabled before LT

Link training will sometimes fail if the DP link is enabled when
tc_main_link_enable() is called. The driver makes sure the DP link is
disabled when the DP output is disabled, and we never enable the DP
without first disabling it, so this should never happen.

However, as the HW behavior seems to be somewhat random if DP link has
erroneously been left enabled, let's add a WARN_ON() for the case and
set DP0CTL to 0.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190528082747.3631-13-tomi.valkeinen@ti.com
drivers/gpu/drm/bridge/tc358767.c