OSDN Git Service

[LoopVectorize] Don't consider conditional-load dereferenceability for marked paralle...
authorHal Finkel <hfinkel@anl.gov>
Tue, 26 Apr 2016 02:00:36 +0000 (02:00 +0000)
committerHal Finkel <hfinkel@anl.gov>
Tue, 26 Apr 2016 02:00:36 +0000 (02:00 +0000)
commit681428ed7d4a43ea3a59a6670c434c56b60da4ee
tree2da2e5e1b3a289ad627df2da43d11ec5dd52e12d
parentb9d01c87d6c1425c0509f2273685d3ff6378bd1f
[LoopVectorize] Don't consider conditional-load dereferenceability for marked parallel loops

I really thought we were doing this already, but we were not. Given this input:

void Test(int *res, int *c, int *d, int *p) {
  for (int i = 0; i < 16; i++)
    res[i] = (p[i] == 0) ? res[i] : res[i] + d[i];
}

we did not vectorize the loop. Even with "assume_safety" the check that we
don't if-convert conditionally-executed loads (to protect against
data-dependent deferenceability) was not elided.

One subtlety: As implemented, it will still prefer to use a masked-load
instrinsic (given target support) over the speculated load. The choice here
seems architecture specific; the best option depends on how expensive the
masked load is compared to a regular load. Ideally, using the masked load still
reduces unnecessary memory traffic, and so should be preferred. If we'd rather
do it the other way, flipping the order of the checks is easy.

The LangRef is updated to make explicit that llvm.mem.parallel_loop_access also
implies that if conversion is okay.

Differential Revision: http://reviews.llvm.org/D19512

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@267514 91177308-0d34-0410-b5e6-96231b3b80d8
docs/LangRef.rst
lib/Transforms/Vectorize/LoopVectorize.cpp
test/Transforms/LoopVectorize/X86/force-ifcvt.ll [new file with mode: 0644]