OSDN Git Service

drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines
authorHans de Goede <hdegoede@redhat.com>
Mon, 18 Apr 2022 15:09:36 +0000 (17:09 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 20 Apr 2022 13:46:26 +0000 (16:46 +0300)
commit681f8a5c6e372dbfd2a313ace417e7749543de1d
treeb7ea409aea422d18397490a4cf6bd7f5505c34cc
parent72c3c8d6e5275b19fd2d32ec787e8135a421c7ec
drm/i915: Fix DISP_POS_Y and DISP_HEIGHT defines

Commit 428cb15d5b00 ("drm/i915: Clean up pre-skl primary plane registers")
introduced DISP_POS_Y and DISP_HEIGHT defines but accidentally set these
their masks to REG_GENMASK(31, 0) instead of REG_GENMASK(31, 16).

This breaks the primary display pane on at least pineview machines, fix
the mask to fix the primary display pane only showing black.

Tested on an Acer One AO532h with an Intel N450 SoC.

Fixes: 428cb15d5b00 ("drm/i915: Clean up pre-skl primary plane registers")
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220418150936.5499-1-hdegoede@redhat.com
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
drivers/gpu/drm/i915/i915_reg.h