OSDN Git Service

HID: betop: fix slab-out-of-bounds Write in betop_probe
authorF.A.Sulaiman <asha.16@itfac.mrt.ac.lk>
Tue, 24 Aug 2021 15:07:30 +0000 (20:37 +0530)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 30 Sep 2021 08:08:02 +0000 (10:08 +0200)
commit689e453a9b9c9158522b508876a1ff02ab0c3aa8
tree608735fa78ef32d6c994fd8e6728188938eb400f
parent2990cd10e1ddba92b72872a6646df1a37096c025
HID: betop: fix slab-out-of-bounds Write in betop_probe

Syzbot reported slab-out-of-bounds Write bug in hid-betopff driver.
The problem is the driver assumes the device must have an input report but
some malicious devices violate this assumption.

So this patch checks hid_device's input is non empty before it's been used.

Reported-by: syzbot+07efed3bc5a1407bd742@syzkaller.appspotmail.com
Signed-off-by: F.A. SULAIMAN <asha.16@itfac.mrt.ac.lk>
Reviewed-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-betopff.c