OSDN Git Service

partially fix [3306150] HTML5 video with H/W acceleration blackout (DO NOT MERGE)
authorMathias Agopian <mathias@google.com>
Sat, 15 Jan 2011 01:37:42 +0000 (17:37 -0800)
committerMathias Agopian <mathias@google.com>
Tue, 25 Jan 2011 22:19:13 +0000 (14:19 -0800)
commit68d3478860fecc9b8fbf256796a832a037434555
tree1672d4b5edd7658c9a32b3bd2d933206e971a8b7
parent8aa11d82f33be8089a53feb3ba3c40fd8a33ad95
partially fix [3306150] HTML5 video with H/W acceleration blackout (DO NOT MERGE)

We used to guarantee that a layer in SurfaceFlinger would never be
destroyed before all references (to its ISurface) on the client
side would be released. At some point, this guarantee got
relaxed to allow to free gralloc resources sooner. This last
change was incorrect, because:
- in implementations with reference-counting the gralloc resources
wouldn't be released anyways, until all the mapping were gone
- in implementations without ref counting, the client side
would most likely crash or do something bad
- it also caused the SharedBufferStack slot to be reallocated
to another surface, which could be problematic if the client
continued to use the surface after the window manager destroyed it.

So, we essentially reinstate the guarantee that layers won't be
destroyed until after all references to their ISurface are
released.

NOTE: This doesn't entirely fix 3306150 because there is another
problem there where the Browser continues to use a surface after it
has been destroyed.

also improve SurfaceFlinger 'dumpsys' log

list the purgatory, which shows windows that have been closed,
but for which the client still has references.
libs/ui/GraphicBufferAllocator.cpp
services/surfaceflinger/LayerBase.cpp
services/surfaceflinger/LayerBase.h
services/surfaceflinger/SurfaceFlinger.cpp
services/surfaceflinger/SurfaceFlinger.h