OSDN Git Service

drm/scheduler: Fix lockup in drm_sched_entity_kill()
authorDmitry Osipenko <dmitry.osipenko@collabora.com>
Wed, 23 Nov 2022 00:13:03 +0000 (03:13 +0300)
committerDmitry Osipenko <dmitry.osipenko@collabora.com>
Tue, 3 Jan 2023 11:49:59 +0000 (14:49 +0300)
commit69555549cfa42e10f2fdd2699ed4e34d9d4f392b
tree78ff141b0cf4f63f99b210054139a90f8bd8124f
parent2c55d703391acf7e9101da596d0c15ee03b318a3
drm/scheduler: Fix lockup in drm_sched_entity_kill()

The drm_sched_entity_kill() is invoked twice by drm_sched_entity_destroy()
while userspace process is exiting or being killed. First time it's invoked
when sched entity is flushed and second time when entity is released. This
causes a lockup within wait_for_completion(entity_idle) due to how completion
API works.

Calling wait_for_completion() more times than complete() was invoked is a
error condition that causes lockup because completion internally uses
counter for complete/wait calls. The complete_all() must be used instead
in such cases.

This patch fixes lockup of Panfrost driver that is reproducible by killing
any application in a middle of 3d drawing operation.

Fixes: 2fdb8a8f07c2 ("drm/scheduler: rework entity flush, kill and fini")
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Tested-by: Guilherme G. Piccoli <gpiccoli@igalia.com> # Steam Deck
Link: https://patchwork.freedesktop.org/patch/msgid/20221123001303.533968-1-dmitry.osipenko@collabora.com
drivers/gpu/drm/scheduler/sched_entity.c
drivers/gpu/drm/scheduler/sched_main.c