OSDN Git Service

drbd: fifo_alloc() should use struct_size
authorStephen Kitt <steve@sk2.org>
Fri, 24 Jan 2020 20:03:07 +0000 (21:03 +0100)
committerJens Axboe <axboe@kernel.dk>
Thu, 30 Jan 2020 04:03:33 +0000 (21:03 -0700)
commit6a365874a43c43b227492266f59cd68ecc5a6f83
tree6c1e771042b2d7bbcbb08c61a0baef104ddf8b35
parenta258edbca2d94a4d902daeecb3073c88b57ac7ad
drbd: fifo_alloc() should use struct_size

Switching to struct_size for the allocation in fifo_alloc avoids
hard-coding the type of fifo_buffer.values in fifo_alloc. It also
provides overflow protection; to avoid pessimistic code being
generated by the compiler as a result, this patch also switches
fifo_size to unsigned, propagating the change as appropriate.

Reviewed-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Stephen Kitt <steve@sk2.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/drbd/drbd_int.h
drivers/block/drbd/drbd_nl.c
drivers/block/drbd/drbd_receiver.c
drivers/block/drbd/drbd_worker.c