OSDN Git Service

batman-adv: Avoid spurious warnings from bat_v neigh_cmp implementation
authorSven Eckelmann <sven.eckelmann@openmesh.com>
Mon, 16 Oct 2017 07:31:47 +0000 (09:31 +0200)
committerSimon Wunderlich <sw@simonwunderlich.de>
Tue, 17 Oct 2017 06:09:47 +0000 (08:09 +0200)
commit6a4bc44b012cbc29c9d824be2c7ab9eac8ee6b6f
tree8789ad6764356774116bfa5c4e593a57f6198305
parentbad5680b5052f9d3008a8cfcc0b34ba0da08401d
batman-adv: Avoid spurious warnings from bat_v neigh_cmp implementation

The neighbor compare API implementation for B.A.T.M.A.N. V checks whether
the neigh_ifinfo for this neighbor on a specific interface exists. A
warning is printed when it isn't found.

But it is not called inside a lock which would prevent that this
information is lost right before batadv_neigh_ifinfo_get. It must therefore
be expected that batadv_v_neigh_(cmp|is_sob) might not be able to get the
requested neigh_ifinfo.

A WARN_ON for such a situation seems not to be appropriate because this
will only flood the kernel logs. The warnings must therefore be removed.

Signed-off-by: Sven Eckelmann <sven.eckelmann@openmesh.com>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
net/batman-adv/bat_v.c