OSDN Git Service

platform/chrome: don't report EC_MKBP_EVENT_SENSOR_FIFO as wakeup
authorBrian Norris <briannorris@chromium.org>
Thu, 8 Nov 2018 02:49:39 +0000 (18:49 -0800)
committerBenson Leung <bleung@chromium.org>
Wed, 14 Nov 2018 05:25:28 +0000 (21:25 -0800)
commit6ad16b78a039b45294b1ad5d69c14ac57b2fe706
treec2b3e3f960c321cc03ccb066c960d555c0322ace
parent475b08734edb3695b9396950c87e75d7c72278a8
platform/chrome: don't report EC_MKBP_EVENT_SENSOR_FIFO as wakeup

EC_MKBP_EVENT_SENSOR_FIFO events can be triggered for a variety of
reasons, and there are very few cases in which they should be treated as
wakeup interrupts (particularly, when a certain
MOTIONSENSE_MODULE_FLAG_* is set, but this is not even supported in the
mainline cros_ec_sensor driver yet). Most of the time, they are benign
sensor readings. In any case, the top-level cros_ec device doesn't know
enough to determine that they should wake the system, and so it should
not report the event. This would be the job of the cros_ec_sensors
driver to parse.

This patch adds checks to cros_ec_get_next_event() such that it doesn't
signal 'wakeup' for events of type EC_MKBP_EVENT_SENSOR_FIFO.

This patch is particularly relevant on devices like Scarlet (Rockchip
RK3399 tablet, known as Acer Chromebook Tab 10), where the EC firmware
reports sensor events much more frequently. This was causing
/sys/power/wakeup_count to increase very frequently, often needlessly
interrupting our ability to suspend the system.

Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Benson Leung <bleung@chromium.org>
drivers/platform/chrome/cros_ec_proto.c