OSDN Git Service

crypto: algapi - reject NULL crypto_spawn::inst
authorEric Biggers <ebiggers@google.com>
Sun, 6 Jan 2019 20:46:06 +0000 (12:46 -0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 11 Jan 2019 06:16:58 +0000 (14:16 +0800)
commit6b476662b09c393936e0f62c97ad9988d410fd36
tree46b91d53182b9d37f525880ffde90eae2201e267
parent14aa1a839a33b4ade7479ffcad8a5fabe5cc4000
crypto: algapi - reject NULL crypto_spawn::inst

It took me a while to notice the bug where the adiantum template left
crypto_spawn::inst == NULL, because this only caused problems in certain
cases where algorithms are dynamically loaded/unloaded.

More improvements are needed, but for now make crypto_init_spawn()
reject this case and WARN(), so this type of bug will be noticed
immediately in the future.

Note: I checked all callers and the adiantum template was the only place
that had this wrong.  So this WARN shouldn't trigger anymore.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/algapi.c