OSDN Git Service

ASoC: Intel: sof_sdw: avoid crash if invalid DSP topology loaded
authorKai Vehmanen <kai.vehmanen@linux.intel.com>
Fri, 17 Jul 2020 21:13:35 +0000 (16:13 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 20 Jul 2020 15:08:22 +0000 (16:08 +0100)
commit6b540ac763e9d11506ec1eb6b0fadc70292bb4a6
tree3a3917b1598000c02343b4b11749f2b12ed985b4
parent15ef2ea035db7bcb9a9d0bf3747fbb7dde67dd97
ASoC: Intel: sof_sdw: avoid crash if invalid DSP topology loaded

The mc_private->hdmi_pcm_list is populated by elements loaded during
DSP topology load. Valid topologies for this machine driver will always
have PCM nodes for HDMI, but driver should fail gracefully even in the case
this is not true. Add a sanity check to sof_sdw_hdmi_card_late_probe()
for this case. Without the fix, a null pcm handle gets dereferenced.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@linux.intel.com>
Link: https://lore.kernel.org/r/20200717211337.31956-5-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/sof_sdw_hdmi.c