OSDN Git Service

net: qcom/emac: Fix use after free bug in emac_remove due to race condition
authorZheng Wang <zyytlz.wz@163.com>
Sat, 18 Mar 2023 08:05:26 +0000 (16:05 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 20 Mar 2023 09:11:18 +0000 (09:11 +0000)
commit6b6bc5b8bd2d4ca9e1efa9ae0f98a0b0687ace75
treea11344877b96de3dac501949f9f01d3e87825f7d
parenta8eff03545d4cef12ae66a1905627c1818a0f81a
net: qcom/emac: Fix use after free bug in emac_remove due to race condition

In emac_probe, &adpt->work_thread is bound with
emac_work_thread. Then it will be started by timeout
handler emac_tx_timeout or a IRQ handler emac_isr.

If we remove the driver which will call emac_remove
  to make cleanup, there may be a unfinished work.

The possible sequence is as follows:

Fix it by finishing the work before cleanup in the emac_remove
and disable timeout response.

CPU0                  CPU1

                    |emac_work_thread
emac_remove         |
free_netdev         |
kfree(netdev);      |
                    |emac_reinit_locked
                    |emac_mac_down
                    |//use netdev
Fixes: b9b17debc69d ("net: emac: emac gigabit ethernet controller driver")
Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qualcomm/emac/emac.c