OSDN Git Service

mfd: core: Fix double-free in mfd_remove_devices_fn()
authorDmitry Osipenko <digetx@gmail.com>
Mon, 17 Aug 2020 23:50:48 +0000 (02:50 +0300)
committerLee Jones <lee.jones@linaro.org>
Mon, 24 Aug 2020 13:23:55 +0000 (14:23 +0100)
commit6b6cf2b5debd42de39afd8ac84b60faeca62cfaf
treef6858b75e310ea2576f4f794ff9e36db405478fc
parent9123e3a74ec7b934a4a099e98af6a61c2f80bbf5
mfd: core: Fix double-free in mfd_remove_devices_fn()

The pdev.mfd_cell is released by platform_device_release(), which is
invoked by platform_device_unregister(). Hence mfd_remove_devices_fn()
shouldn't release the cell variable. The double-free bug is reported KASAN
during of MFD driver module removal.

Fixes: 466a62d7642f ("mfd: core: Make a best effort attempt to match devices with the correct of_nodes")
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/mfd-core.c