OSDN Git Service

lpfc: Fix return value in __lpfc_nvme_ls_abort
authorJames Smart <jsmart2021@gmail.com>
Wed, 20 May 2020 18:59:29 +0000 (11:59 -0700)
committerChristoph Hellwig <hch@lst.de>
Wed, 27 May 2020 05:12:41 +0000 (07:12 +0200)
commit6b6e89636f51581895922780c3c4fd51bb9e1483
tree2dae0e98d542d1b1c4fd5273f7775a34ce668375
parent4e57e0b9f343fd14497ab04b2bc08c1784830b9d
lpfc: Fix return value in __lpfc_nvme_ls_abort

A static checker reported the following issue:
  drivers/scsi/lpfc/lpfc_nvmet.c:1366 lpfc_nvmet_ls_abort()
  warn: 'ret' can be either negative or positive

The comment indicates a non-zero value indicates error in the
form of -Exxx, but the code is returning "1".

Fix the code to return -EINVAL to be compliant to comment.

Fixes: e96a22b0b7c2 ("lpfc: Refactor Send LS Abort support")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/lpfc/lpfc_nvme.c